feat: upgrade sarama from Shopify v1.30.1 to IBM v1.48.0#274
Open
Danish-sarwar1 wants to merge 3 commits intomasterfrom
Open
feat: upgrade sarama from Shopify v1.30.1 to IBM v1.48.0#274Danish-sarwar1 wants to merge 3 commits intomasterfrom
Danish-sarwar1 wants to merge 3 commits intomasterfrom
Conversation
|
Important Review skippedToo many files! This PR contains 299 files, which is 149 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (299)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Replace all github.com/Shopify/sarama imports with github.com/IBM/sarama - Fix error comparisons to use errors.Is() pattern - Adds Kafka 4.x protocol support (fixes OffsetCommit v1 rejection) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Danish-sarwar1
force-pushed
the
feat/upgrade-sarama-ibm
branch
from
7561b8e to
f453c44
Compare
added 2 commits
May 8, 2026 15:49
go.mod requires go 1.25.0 after the IBM/sarama upgrade. Bump the build-container image and Travis host Go version to match, and reformat two doc comments to satisfy Go 1.19+ gofmt rules.
- LeaderElectionID '854ae6e3.' -> 'redshiftsink-operator-leader' for readability. Note: rolling deploys across this change will briefly hold two distinct leases. - realtime_calculator.go: drop unused SQL fragment accidentally appended after the package's last function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Kafka client library for Kafka 4.x support. Fixes OffsetCommit v1 rejection (EOF errors) on Kafka 4.1.1. Import path: Shopify/sarama -> IBM/sarama. Go 1.25+.